From e11ac01f22de390a6f797e6766d0b5caf8d9fd6c Mon Sep 17 00:00:00 2001 From: Chengxuan Xing Date: Wed, 30 Aug 2023 16:22:30 +0100 Subject: [PATCH 1/3] Update CODEOWNERS Signed-off-by: Chengxuan Xing --- CODEOWNERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 01106b8d..587462ba 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1,7 +1,7 @@ # SPDX-License-Identifier: Apache-2.0 -# FireFly Core Maintainers -* @peterbroadhurst @nguyer @awrichar +# FireFly transaction manager maintainers +* @hyperledger/firefly-transaction-manager-maintainers # FireFly Documentation Maintainers -/docs @peterbroadhurst @nguyer @awrichar @nickgaski \ No newline at end of file +/docs @peterbroadhurst @nguyer @awrichar @nickgaski From c73ef06ecba3ad0f0a8c911fcdea32ec6a13bf20 Mon Sep 17 00:00:00 2001 From: Chengxuan Xing Date: Thu, 14 Sep 2023 16:25:04 +0100 Subject: [PATCH 2/3] address code owner comments Signed-off-by: Chengxuan Xing --- CODEOWNERS | 4 ---- 1 file changed, 4 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 587462ba..8ef41659 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1,7 +1,3 @@ # SPDX-License-Identifier: Apache-2.0 -# FireFly transaction manager maintainers * @hyperledger/firefly-transaction-manager-maintainers - -# FireFly Documentation Maintainers -/docs @peterbroadhurst @nguyer @awrichar @nickgaski From 35f48c7fd53527c99d83fa74045cc0d8f6346b9c Mon Sep 17 00:00:00 2001 From: Chengxuan Xing Date: Thu, 14 Sep 2023 16:32:09 +0100 Subject: [PATCH 3/3] update maintainer.md Signed-off-by: Chengxuan Xing --- MAINTAINERS.md | 44 +++----------------------------------------- 1 file changed, 3 insertions(+), 41 deletions(-) diff --git a/MAINTAINERS.md b/MAINTAINERS.md index 5ceb7e93..07f1612f 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -1,4 +1,4 @@ -# Maintainers +# firefly-transaction-manager-maintainers The following is the list of current maintainers this repo: @@ -7,46 +7,8 @@ The following is the list of current maintainers this repo: | Peter Broadhurst | peterbroadhurst | peter.broadhurst@kaleido.io | peterbroadhurst | | Nicko Guyer | nguyer | nicko.guyer@kaleido.io | nguyer | | Andrew Richardson | awrichar | andrew.richardson@kaleido.io | Andrew.Richardson | - +| Chengxuan Xing | Chengxuan | chengxuan.xing@kaleido.io | chengxuanxing | This list is to be kept up to date as maintainers are added or removed. -# Expectations of Maintainers - -Maintainers are expected to regularly: - -- Make contributions to FireFly code repositories including code or documentation -- Review pull requests -- Investigate open GitHub issues -- Participate in Community Calls - -# Becoming a Maintainer - -The FireFly Project welcomes and encourages people to become maintainers of the project if they are interested and meet the following criteria: - -## Criteria for becoming a member - -- Expressed interest and commitment to meet the expectations of a maintainer for at least 6 months -- A consistent track record of contributions to FireFly code repositories which could be: - - Enhancements - - Bug fixes - - Tests - - Documentation -- A consistent track record of helpful code reviews on FireFly code repositories -- Regular participation in Community Calls -- A demonstrated interest and aptitude in thought leadership within the FireFly Project -- Sponsorship from an existing maintainer - -There is no specific quantity of contributions or pull requests, or a specific time period over which the candidate must prove their track record. This will be left up to the discretion of the existing maintainers. - -## Process for becoming a maintainer - -Once the above criteria have been met, the sponsoring maintainer shall propose the addition of the new maintainer at a public Community Call. Existing maintainers shall vote at the next public Community Call whether the new maintainer should be added or not. Proxy votes may be submitted via email _before_ the meeting. A simple majority of the existing maintainers is required for the vote to pass. - -## Maintainer resignation - -While maintainers are expected in good faith to be committed to the project for a significant period of time, they are under no binding obligation to do so. Maintainers may resign at any time for any reason. If a maintainer wishes to resign they shall open a pull request to update the maintainers list removing themselves from the list. - -## Maintainer inactivity - -If a maintainer has remained inactive (not meeting the expectations of a maintainer) for a period of time (at least several months), an email should be sent to that maintainer noting their inactivity and asking if they still wish to be a maintainer. If they continue to be inactive after being notified via email, an existing maintainer may propose to remove the inactive maintainer at a public Community Call. Existing maintainers shall vote at the next public Community Call whether the inactive maintainer should be removed or not. Proxy votes may be submitted via email _before_ the meeting. A simple majority of the existing maintainers is required for the vote to pass. +For the full list of maintainers across all repos, the expectations of a maintainer and the process for becoming a maintainer, please see the [FireFly Maintainers page on the Hyperledger Wiki](https://wiki.hyperledger.org/display/FIR/Maintainers). \ No newline at end of file