Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oob builder for messages crate #949

Open
Patrik-Stas opened this issue Aug 22, 2023 · 1 comment
Open

Oob builder for messages crate #949

Patrik-Stas opened this issue Aug 22, 2023 · 1 comment
Assignees
Labels
good first issue Good for newcomers

Comments

@Patrik-Stas
Copy link
Contributor

Patrik-Stas commented Aug 22, 2023

Building OOB invitation is fundamental way for anyone to get started with aries-vcx, in its current state. The first thing you ever need if you want to simulate a basic use case with aries-vcx is to create the oob invitation.
This need came up for example in:

Currently in aries_vcx/src/handlers/out_of_band there's OutOfBandSender which is position on same level like other protocol handlers, but in fact, this is just a builder for OOB messages.
More-over, working with the OutOfBandSender is currently difficult, because it's method

pub fn append_service(mut self, service: &OobService) -> Self {

ultimately requires you to import diddoc_legacy into your project, which is not obvious.

Proposal:

  • There's already established consensus that builder for messages crate is necessary, and constructing message by hand is currently cumbersome.
  • So let's use this as opportunity to create first message builder, specifically for oob invites; also get rid of OutOfBandSender in the process

Additional note:

There's also OutOfBandReceiver - we'll get rid of that in separate step - it contains method. nonmediated_connection_exists which is being used in some NodeJS tests.

@mirgee mirgee added the good first issue Good for newcomers label Aug 22, 2023
@bobozaur bobozaur self-assigned this Sep 7, 2023
@Patrik-Stas
Copy link
Contributor Author

We now have builders for Messages crate, but we should yet do something about OutOfBandSender and OutOfBandReceiver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants