Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Did type in messages crate #1165

Open
Patrik-Stas opened this issue Mar 23, 2024 · 1 comment · May be fixed by #1179
Open

Use Did type in messages crate #1165

Patrik-Stas opened this issue Mar 23, 2024 · 1 comment · May be fixed by #1179
Labels
good first issue Good for newcomers

Comments

@Patrik-Stas
Copy link
Contributor

Patrik-Stas commented Mar 23, 2024

@Patrik-Stas Patrik-Stas changed the title Use Did type in messages Use Did type in messages crate Mar 23, 2024
@Patrik-Stas Patrik-Stas added the good first issue Good for newcomers label Mar 23, 2024
@GHkrishna
Copy link

Hello @Patrik-Stas I have created a PR #1171 for this.

Apart from the instances resolved in the PR, there are multiple other instances in agent, misc, etc where did is typed as a string.

Do I convert the PR to draft and add those instances as well?

@GHkrishna GHkrishna linked a pull request Apr 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
2 participants