Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

[CI] Actions should only pull go deps once #1282

Open
gregdhill opened this issue Oct 2, 2019 · 2 comments
Open

[CI] Actions should only pull go deps once #1282

gregdhill opened this issue Oct 2, 2019 · 2 comments
Labels
area/test bug/confirmed type/good starter issue this issue is limited in scope otherwise suitable for new contributors

Comments

@gregdhill
Copy link
Contributor

In a couple of the test steps that require docker builds we pull in our go dependencies twice. We should ideally vendor these first and reuse to speed up the pipeline.
@gregdhill gregdhill added bug/confirmed area/test type/good starter issue this issue is limited in scope otherwise suitable for new contributors type/hacktoberfest labels Oct 2, 2019
@deepakchethan
Copy link
Contributor

According to actions/setup-go. It automatically caches go, which can be seen here. So doesn't vendoring this first make it redundant?

@gregdhill
Copy link
Contributor Author

Correct, however this unfortunately is not the case with our docker build steps which do not share this cache.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/test bug/confirmed type/good starter issue this issue is limited in scope otherwise suitable for new contributors
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregdhill @deepakchethan