Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default isLegacyGetEnabled to false for Data and Cache api #550

Open
TillaTheHun0 opened this issue Feb 21, 2023 · 0 comments
Open

default isLegacyGetEnabled to false for Data and Cache api #550

TillaTheHun0 opened this issue Feb 21, 2023 · 0 comments
Labels
cache cache service data

Comments

@TillaTheHun0
Copy link
Member

Related to #531 , this flag is currently defaulted to true. We eventually will need to update this flag to default to false, in prep for eventually removing the flag.

This should be a major release of hyper core

As a hyper developer
I would like hyper data service and hyper cache service "get" apis to return a hyper response shape, default
So that consumers can start to receive the hyper response shape that will be used, going forward

Scenarios

Default to hyper response shape

GIVEN I am a developer
AND I am calling the Data Service "get document" or Cache Service "get value" api
WHEN I do NOT provide the `isLegacyGetEnabled` flag, ie. set `X-HYPER-LEGACY-GET` header
THEN I will receive the hyper response shape

Opt-in to legacy shape

GIVEN I am a developer
AND I am calling the Data Service "get document" or Cache Service "get value" api
WHEN I DO provide the `isLegacyGetEnabled` flag, ie. set `X-HYPER-LEGACY-GET` header
THEN I will receive the legacy shape (the document or value directly)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cache cache service data
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant