Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only export public declarations into the website #4

Open
tothambrus11 opened this issue Jun 26, 2024 · 1 comment
Open

Only export public declarations into the website #4

tothambrus11 opened this issue Jun 26, 2024 · 1 comment
Labels
good first issue Good for newcomers website generation Issues related to the backend (generating the static site)

Comments

@tothambrus11
Copy link
Collaborator

Currently, there is no filtering for symbols in the website generation. Readers are only interested in declarations that they can use from outside the module, so we should filter for public declarations. Refer to https://github.com/hylo-lang/specification/blob/main/spec.md#modifiers for details.

Relevant files from Hylo frontend: AccessModifier.swift, all files within Frontend/AST/Decl.
Relevant folder from HyloDoc: Sources/WebsiteGen/

@tothambrus11 tothambrus11 added good first issue Good for newcomers website generation Issues related to the backend (generating the static site) labels Jun 26, 2024
@tothambrus11
Copy link
Collaborator Author

It is currently a bit convoluted the way we render members in traits and product type pages: we convert them to targets, filter them and convert them back. This should be also simplified.
isSupportedDecl in PartialTargetResolution.swift should be removed since we support everything except stuff where we don't traverse into anymore. It should be replaced with another function that checks if the declaration is publicly exposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers website generation Issues related to the backend (generating the static site)
Projects
None yet
Development

No branches or pull requests

1 participant