Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Code Duplication #16

Open
msmith-ccom opened this issue Jan 17, 2020 · 1 comment
Open

Reduce Code Duplication #16

msmith-ccom opened this issue Jan 17, 2020 · 1 comment
Labels
Priority: Low Tag: Python Work is done in Python Envs Type: Improvements Iteration on existing feature

Comments

@msmith-ccom
Copy link
Collaborator

msmith-ccom commented Jan 17, 2020

Issue: Codeacy indicates significant code duplication. There are large sections of the code base that have similar functionality that could be compressed. An example is below.

Example: When adding a raw file, three different 'add' methods are called, all with almost the exact same code.
project_info.add_raw:
pycharm64_a5BkfAeSal

raws.add_raw:
pycharm64_CEuVkAJ52y

process.add_process:
pycharm64_4QDke59P1M

Objective: Refactor code to reduce complexity and duplication

@msmith-ccom msmith-ccom added Type: Improvements Iteration on existing feature Priority: Low Tag: Python Work is done in Python Envs labels Jan 17, 2020
@msmith-ccom msmith-ccom added this to the back-end milestone Jan 17, 2020
@msmith-ccom msmith-ccom removed this from the back-end milestone Mar 9, 2020
@msmith-ccom
Copy link
Collaborator Author

I can envision a preferable solution where there is a nc_file manager. adding a file (the injection point is currently in the project class) would involve passing the file name, along with the project_info.nc path, raw and process directory paths to the file_manager, which could then create the appropriate files and track status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Tag: Python Work is done in Python Envs Type: Improvements Iteration on existing feature
Projects
None yet
Development

No branches or pull requests

1 participant