Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use semantic versioning in git tags #785

Open
bderrly opened this issue Apr 17, 2024 · 1 comment
Open

Use semantic versioning in git tags #785

bderrly opened this issue Apr 17, 2024 · 1 comment

Comments

@bderrly
Copy link
Contributor

bderrly commented Apr 17, 2024

I have recently begun working on a tool which will create HumioRepository custom resources using the kubernetes client. I attempted to import this module go get github.com/humio/humio-operator so that I could import github.com/humio/humio-operator/api/v1alpha1 but the only version that go get will download is the ancient v0.3.0. Using semantic versioning is required for being published by the pkg.go.dev site.

@bderrly
Copy link
Contributor Author

bderrly commented Apr 17, 2024

I believe the best way forward is to have each directory under the api directory be the root of a Go module. This way tagging can be done separately from the root of the repository.

For example, the api/v1alpha1 directory would have a tag like api/v1alpha1/v0.20.3

https://go.dev/ref/mod#vcs-version and https://go.dev/ref/mod#resolve-pkg-mod are useful here.

I can put together a PR to make these changes if there are no disagreements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant