Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve node pool experience #666

Open
ryanfaircloth opened this issue Feb 15, 2023 · 2 comments
Open

Improve node pool experience #666

ryanfaircloth opened this issue Feb 15, 2023 · 2 comments

Comments

@ryanfaircloth
Copy link
Contributor

When creating a node pool a substantial portion of the work is copy and past making the CR difficult to sustain.

  • When using node pools the "root spec" should be a template for the pools and not create a pool itself
  • Each pool (ALL, ui, ingest) should be defined in node pools
  • Information from the root spec should be the base for each pool with the individual pool choices taking precidence
@jswoods
Copy link
Contributor

jswoods commented Apr 12, 2023

I agree there can be some improvement here. We are working to enable a config that will allow us to define only node pools and nothing at the "base" spec. The goal would be to eventually remove these types of configs from the base part of the spec.

In order to align with that plan and not add more confusion about inheritance, I would suggest we add a new field to the base spec, along the lines of defaultNodePoolAttributes or commonNodePoolAttributes, which then are inherited by any of the node pools that are defined in the node pool list.

@ryanfaircloth
Copy link
Contributor Author

I like this solution it's easy to understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants