Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rotation #123

Open
roborourke opened this issue Sep 1, 2020 · 1 comment
Open

Support rotation #123

roborourke opened this issue Sep 1, 2020 · 1 comment

Comments

@roborourke
Copy link
Contributor

In WP 5.5 the image block introduced inline image editing. We could potentially hijack the API endpoint that generates a modified image if we also supported rotation. Rotation does add a bit of complexity when calculating & applying crop dimensions however. We'll need to apply this consistently eg.

  • Rotate & then crop (crop dimensions are for rotated image)
  • Crop & then rotate (crop dimensions are pre-rotation)

The WP editor assumes rotating and then cropping, and that fits the model of values an image editor UI is likely to be able to produce so I feel it's the best approach.

@joehoyle
Copy link
Member

joehoyle commented Sep 4, 2023

Hmm what would be the advantage to using Tachyon to do this instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants