From b989829b4b04f7c4318d4d5a42a3d283c90d6243 Mon Sep 17 00:00:00 2001 From: Grazfather Date: Fri, 25 Aug 2023 20:22:04 -0400 Subject: [PATCH] Handle GDB hating quotes for set logging --- gef.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/gef.py b/gef.py index fea82803c..ef783d064 100644 --- a/gef.py +++ b/gef.py @@ -1935,14 +1935,15 @@ def __exit__(self, *exc: Any) -> None: class RedirectOutputContext: - def __init__(self, to: str = "/dev/null") -> None: - self.redirection_target_file = to + def __init__(self, to_file: str = "/dev/null") -> None: + if " " in to_file: raise Exception("Target filepath cannot contain spaces") + self.redirection_target_file = to_file return def __enter__(self) -> None: """Redirect all GDB output to `to_file` parameter. By default, `to_file` redirects to `/dev/null`.""" gdb.execute("set logging overwrite") - gdb.execute(f"set logging file '{self.redirection_target_file}'") + gdb.execute(f"set logging file {self.redirection_target_file}") gdb.execute("set logging redirect on") gdb.execute("set logging on") return @@ -1956,8 +1957,9 @@ def __exit__(self, *exc: Any) -> None: def enable_redirect_output(to_file: str = "/dev/null") -> None: """Redirect all GDB output to `to_file` parameter. By default, `to_file` redirects to `/dev/null`.""" + if " " in to_file: raise Exception("Target filepath cannot contain spaces") gdb.execute("set logging overwrite") - gdb.execute(f"set logging file '{to_file}'") + gdb.execute(f"set logging file {to_file}") gdb.execute("set logging redirect on") gdb.execute("set logging on") return @@ -8786,7 +8788,7 @@ def get_frames_size(self) -> int: def trace(self, loc_start: int, loc_end: int, depth: int) -> None: info(f"Tracing from {loc_start:#x} to {loc_end:#x} (max depth={depth:d})") logfile = f"{self['tracefile_prefix']}{loc_start:#x}-{loc_end:#x}.txt" - with RedirectOutputContext(to=logfile): + with RedirectOutputContext(to_file=logfile): hide_context() self.start_tracing(loc_start, loc_end, depth) unhide_context() @@ -9184,7 +9186,7 @@ def do_invoke(self, _: List[str]) -> None: nb_installed_breaks = 0 - with RedirectOutputContext(to="/dev/null"): + with RedirectOutputContext(to_file="/dev/null"): for function_name in dangerous_functions: argument_number = dangerous_functions[function_name] FormatStringBreakpoint(function_name, argument_number)