Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ImportError: cannot import name 'NoneType' from 'types' on main in Python <= 3.9 #35829

Closed
wants to merge 1 commit into from
Closed

Fix ImportError: cannot import name 'NoneType' from 'types' on main in Python <= 3.9 #35829

wants to merge 1 commit into from

Conversation

harupy
Copy link
Contributor

@harupy harupy commented Jan 22, 2025 •
edited
Loading

What does this PR do?

Fixes #35827

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@harupy harupy changed the title Update chat_template_utils.py Fix ImportError: cannot import name 'NoneType' from 'types' on main in Python <= 3.9 Jan 22, 2025
Rocketknight1
Rocketknight1 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cc @aymeric-roucher who added that line!

@Rocketknight1
Copy link
Member

also @harupy you can pip install transformers[quality] and then make fixup to get rid of the CI issues

@Rocketknight1 Rocketknight1 mentioned this pull request Jan 22, 2025
Merged
@Rocketknight1
Copy link
Member

Closing in favour of #35843 - we got two PRs at the same time to fix this issue, and that one seemed a little simpler, plus I was able to merge it sooner.

This was still a good PR, though - please keep contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rocketknight1 Rocketknight1 Rocketknight1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'NoneType' from 'types' on main in Python 3.9
2 participants
@harupy @Rocketknight1