LIMIT and OFFSET does not user args but hardcoded numbers

[stavros-k]

While it is safe from sql injection as it uses strconv.Itoa.
I believe having those as args will help db with query plan caching. I might be totally wrong here, but I just noticed it while comparing sql output with sql generated from go-jet.

Feel free to close if you think its fine!

[huandu]

The reason for this design is that when concatenating the SQL limit and offset, different expressions need to be formed based on various database systems. For example, MySQL requires LIMIT n OFFSET m, while Informix uses SKIP m FIRST n, and other database systems have their own distinct syntaxes. This has led me to manually handle the values of limit and offset, which in turn has caused difficulties in placing these values into args.

Of course, these technical challenges can always be resolved. I just haven't seen the benefits of changing this detail before. Your proposal of query plan caching is quite enlightening, and I think it's time to consider optimizing this detail. Allow me some time to contemplate the relevant design before continuing the discussion.