Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing test for excluded fields #4

Open
phil-wpks opened this issue Oct 15, 2020 · 1 comment
Open

Missing test for excluded fields #4

phil-wpks opened this issue Oct 15, 2020 · 1 comment

Comments

@phil-wpks
Copy link

Hi @jorostoyanov ,

Thanks for the plugin !

I tried filtering some fields and realised the following code seems to be missing in order to get it working :
carbon-fields-yoast.js:line 119

		
$.each(fields, function (index, field) {
			// we can skip complex fields, as their children are
			// already present in the main fields array
			if (field.type === 'complex') {
				return;
			}
			// This test seems to be missing?
			if ( _self.shouldSkipField(field) ) {
				return;
			}

			fieldsContentParts.push(_self.getFieldContent(field));
		});

Could you confirm and add it to the repo ?

Many thanks,

@phil-wpks
Copy link
Author

@htmlburger-git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant