Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception when using modifiers #138

Open
pieter-v opened this issue Feb 23, 2021 · 1 comment
Open

Exception when using modifiers #138

pieter-v opened this issue Feb 23, 2021 · 1 comment

Comments

@pieter-v
Copy link
Contributor

It works with [email protected] but fails with [email protected]

I have a simple template

<div
  style={{this.style}}
  class="..."
  title={{this.title}}
  role="button"
  ...attributes
  {{recognize-gesture "tap"}}
  {{on "tap" this.tap}}
></div>

When rendering this template the following exception occurs:

TypeError: Cannot read property 'lookup' of undefined
    at new RecognizeGestureModifier (recognize-gesture.js:14)
    at Function.create (modifier-native.js:23)
    at Object.create (manager.js:671)
    at ClassBasedModifierManager.createModifier (modifier-manager.js:17)
    at manager.js:680
    at deprecateMutationsInTrackingTransaction (validator.js:144)
    at CustomModifierManager.create (manager.js:679)
    at invokeModifier (runtime.js:2658)
    at Object.evaluate (runtime.js:2604)
    at AppendOpcodes.evaluate (runtime.js:1225)
@pieter-v
Copy link
Contributor Author

pieter-v commented Mar 4, 2021

The pull request #137 fixes this issue.
Would it be possible to release it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant