Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shouldInclude #38

Open
sol opened this issue Jan 9, 2021 · 1 comment · May be fixed by #43
Open

Add shouldInclude #38

sol opened this issue Jan 9, 2021 · 1 comment · May be fixed by #43

Comments

@sol
Copy link
Member

sol commented Jan 9, 2021 

shouldInclude :: (Foldable t, Show a, Eq a) => t a -> a -> Expectation
declension pushed a commit to declension/hspec-expectations that referenced this issue Apr 28, 2021
Extra expectations: shouldInclude & shouldIncludeAll
fe08705 
 * Add a new `shouldInclude` (hspec#38 / hspec#35)
 * Also, a more general `shouldIncludeAll` which tests provides subset-like expectations (generalised to any `Foldable`s), with helpful (hopefully) messaging about missing elements
 * Replicate a few unexported helper functions, rather than mess with the overall structure
 * Add some tests around these
 * Update Hpack / Cabal

Closes hspec#38
declension added a commit to declension/hspec-expectations that referenced this issue Apr 28, 2021
@declension
Extra expectations: shouldInclude & shouldIncludeAll
5d3243d 
 * Add a new `shouldInclude` (hspec#38 / hspec#35)
 * Also, a more general `shouldIncludeAll` which tests provides subset-like expectations (generalised to any `Foldable`s), with helpful (hopefully) messaging about missing elements
 * Replicate a few unexported helper functions, rather than mess with the overall structure
 * Add some tests around these
 * Update Hpack / Cabal

Closes hspec#38
declension added a commit to declension/hspec-expectations that referenced this issue Apr 28, 2021
@declension
Extra expectations: shouldInclude & shouldIncludeAll
c2f0a07 
 * Add a new `shouldInclude` (hspec#38 / hspec#35)
 * Also, a more general `shouldIncludeAll` which provides subset-like expectations (generalised to any `Foldable`s), with helpful (hopefully) messaging about missing elements
 * Add some tests around these
 * Replicate a few unexported helper functions, rather than mess with the overall structure
 * Update Hpack / Cabal

Closes hspec#38
@declension declension linked a pull request Apr 28, 2021 that will close this issue
Open
@declension
Copy link

@sol I've had a stab at this in #43 if you're interested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add shouldInclude & shouldIncludeAll declension/hspec-expectations
2 participants
@sol @declension