Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to help link points to wrong repo #104

Closed
charliemirabile opened this issue Oct 18, 2024 · 2 comments
Closed

How to help link points to wrong repo #104

charliemirabile opened this issue Oct 18, 2024 · 2 comments

Comments

@charliemirabile
Copy link

Since latest commit fbf0649 ("use tables-common to unify my tables") the specific link to this repo and the suggestion that people say if they are using this project in issue #12 that was present before has been removed:
fbf0649#diff-2d1d8eb95b7341ac68642cc6a2eab34340e8bdeda5222bc061e55ca7a42fc726L147-L156

<h2>How to help</h2>
    <p>
    Sources used to generate table are available in <a
    href="https://github.com/hrw/syscalls-table">git repository at github</a>.
    Patches are always welcomed.
    </p>
    <p>
    If this table helped you in some project then please leave a comment in
    <a href="https://github.com/hrw/syscalls-table/issues/12">issue on GitHub</a>.
    </p>

Instead, the common table has:
https://github.com/hrw/tables-common/blob/eeffc4e095015d9885e8ce708529307f08ddeb45/author-tables-help.inc.j2#L14-L19

<h2>How to help</h2>
    <p>
    Sources used to generate table are available in <a
    href="https://github.com/hrw/arm-socs-table">git repository at github</a>.
    Patches are always welcomed.
    </p>

which includes an incorrect link to the arm-soc-table repo and no mention of issue #12.

@hrw
Copy link
Owner

hrw commented Oct 18, 2024

Thanks for catching it. Will fix.

hrw added a commit to hrw/tables-common that referenced this issue Oct 19, 2024
@charliemirabile in hrw/syscalls-table#104
reported that git repo link is wrong.

This change fixes it.
@hrw hrw closed this as completed in 6f13f12 Oct 19, 2024
hrw added a commit that referenced this issue Oct 19, 2024
@hrw
Copy link
Owner

hrw commented Oct 19, 2024

Aaaand fixed ;D

Thanks again for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants