Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore v7 flags #50

Open
hrw opened this issue Nov 17, 2022 · 1 comment
Open

Ignore v7 flags #50

hrw opened this issue Nov 17, 2022 · 1 comment

Comments

@hrw
Copy link
Owner

hrw commented Nov 17, 2022

Some old Android kernels mix v7 flags with v8 ones. Can be seen in #43:

processor       : 0
Features        : half thumb fastmult vfp edsp neon vfpv3 tls vfpv4 idiva idivt lpae evtstrm aes pmull sha1 sha2 crc32
CPU implementer : 0x41
CPU architecture: 8
CPU variant     : 0x0
CPU part        : 0xd03
CPU revision    : 4

Have to add code to ignore v7 ones.
@hrw hrw closed this as completed in d03469b Nov 17, 2022
@hrw
Copy link
Owner Author

hrw commented Dec 11, 2022

Nope, need to warn when they appear and refuse to add such entries.

Flags in 32-bit mode are not complete compared to 64-bit mode.

@hrw hrw reopened this Dec 11, 2022
hrw added a commit that referenced this issue Dec 11, 2022
@hrw
dropped Exynos 7870
b818f04 
Dump was from 32-bit userspace so flags were not complete. Have to stop
adding such ones.

Related: #43 #50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hrw