Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrototypingUI does not update the values of ValueBehaviors in Spawners #161

Open
leogeier opened this issue Sep 6, 2023 · 5 comments
Open

Comments

@leogeier
Copy link
Collaborator

leogeier commented Sep 6, 2023

No description provided.

@jgrenda
Copy link
Collaborator

jgrenda commented Sep 7, 2023

reproduction_failure
@leogeier are there any reproduction examples?

@tom95
Copy link
Contributor

tom95 commented Sep 7, 2023

Connect a value_changed from the value to a Label's text. Changing the value does not change the text (yesterday at least :)).

@JulianEgbert
Copy link
Collaborator

JulianEgbert commented Sep 8, 2023

I think with the current changes from Finn the Value gets changed. I tried this with the "game_car" example (updated version committed just now).

Those changes currently change the ValueBehaviors initial values during runtime, meaning that after playing the game, the previous values will also be overwritten by those changed during runtime.

@jgrenda
Copy link
Collaborator

jgrenda commented Sep 9, 2023

#161_not_reproduced
Can not reproduce at this point in time

@jgrenda jgrenda closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2023
@tom95
Copy link
Contributor

tom95 commented Sep 10, 2023

I've just re-checked, indeed the original description was incorrect: the update only does not occur if the ValueBehavior is in a Spawner (which makes sense, it willl only update the value for its offscreen template).

I would say the expectation is that the PrototypingUI will be aware of the fact that a ValueBehavior belongs to a Spawner's template and consequently updates all instances as well. I would be optimistic that this is comparatively easy to do, especially with @jgrenda 's recent changes?

(updated issue title to better reflect problem)

@tom95 tom95 reopened this Sep 10, 2023
@tom95 tom95 changed the title PrototypingUI does not update the values of ValueBehaviors PrototypingUI does not update the values of ValueBehaviors in Spawners Sep 10, 2023
@jgrenda jgrenda removed their assignment Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants