Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling microbreaks does not stop the next one #503

Closed
Quitch opened this issue Dec 9, 2019 · 3 comments
Closed

Disabling microbreaks does not stop the next one #503

Quitch opened this issue Dec 9, 2019 · 3 comments

Comments

@Quitch
Copy link

Quitch commented Dec 9, 2019

Prerequisites

  • [X ] I'm using latest version: v0.21.0
  • [X ] I've checked Known issues

Description

When disabling microbreaks in settings, if a microbreak is the next scheduled break type, the schedule is not updated until that microbreak has occurred.

Operating system: Windows 10 Pro x64 1909

Steps to Reproduce

  1. Ensure a microbreak is scheduled to occur next
  2. Disable microbreaks

Expected behavior: The next break will be a break

Actual behavior: The scheduled microbreak will occur

Reproduces how often: 100%

Additional Information

Resetting breaks after making the change correctly updates the schedule

@hovancik
Copy link
Owner

hovancik commented Dec 9, 2019

Hi, you are right. It is like that with more settings, ie when you change time between breaks it is changed only after next break. My thinking was that I don't wanna reset breaks everytime someone changes the settings, but what you say makes sense, it should be changes right away.

@Quitch
Copy link
Author

Quitch commented Dec 9, 2019

Ideal behaviour would be that the break timings are unaffected and microbreaks simply removed from the schedule, but an automatic reset would work too.

@hovancik
Copy link
Owner

closing in favor of #1248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants