Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Use noticeme based on a cron schedule #1427

Open
2 tasks
wwahammy opened this issue Dec 6, 2022 · 2 comments
Open
2 tasks

[FEATURE] Use noticeme based on a cron schedule #1427

wwahammy opened this issue Dec 6, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@wwahammy
Copy link
Member

wwahammy commented Dec 6, 2022

ClearlyDefined is a great tool but it is a MASSIVE headache to run on every PR. This is due to two problems:

  1. ClearlyDefined is often overloaded
  2. Notices will change in between PRs so people's PRs break for now reason

This would move noticeme verification and updating to running on a regular schedule. For closing, this change will:

  • Remove the noticeme run from inside the PR tasks
  • Create a new workflow for running noticeme that checks if there are changes and, if so, creates a PR and notifies the team

One advantage of doing this is that we can more easily use Dependabot batcher which would save us some work.

@wwahammy wwahammy added the enhancement New feature or request label Dec 6, 2022
@victorear05
Copy link

I'll work on it!

@wwahammy
Copy link
Member Author

@victorear05 Thanks! Please use the changes I just made in react-i18n-currency-input as a guide. The noticeme workflow is viewable at https://github.com/houdiniproject/react-i18n-currency-input/blob/main/.github/workflows/noticeme.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants