Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification Request: homebridge-dummy-cmd-switch #789

Open
YPyltiai opened this issue Dec 31, 2024 · 4 comments
Open

Verification Request: homebridge-dummy-cmd-switch #789

YPyltiai opened this issue Dec 31, 2024 · 4 comments
Labels
awaiting-changes use after review has started - awaiting user to make changes to plugin request-verification

Comments

@YPyltiai
Copy link

Plugin Name

homebridge-dummy-cmd-switch

Link To GitHub Repo

https://github.com/YPyltiai/homebridge-dummy-cmd-switch

Plugin Icon (Optional)

No response

The plugin does not offer the same nor less functionality than that of any existing verified plugin.

🟠 No (please explain in the more information box at the end)

The plugin successfully installs and does not start unless it is configured.

🟢 Yes

The plugin does not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.

🟢 Yes

The plugin does not contain any analytics or calls that enable you to track the user.

🟢 Yes

If the plugin needs to write files to disk (cache, keys, etc.), it stores them inside the Homebridge storage directory.

🟢 Yes

The plugin does not throw unhandled exceptions, the plugin must catch and log its own errors.

🟢 Yes

More Information

There are a few dummy switch plugins but none of them allow running CMD commands on click. The CMD command plugins are no longer maintained either and commonly offer regular on/off switches, which don't make sense either for the use case.

This plugin merges the idea of having dummy momentary switch with being able to run CMD commands on click and is very lightweight to solve just that specific use case.

Technically parts of the functionality are available elsewhere but I couldn't find plugin that solves this use case end-to-end, so built a small new one.

Thanks!

@YPyltiai YPyltiai added pending the label given to a new verification/icon request request-verification labels Dec 31, 2024
Copy link

🔴 The following checks failed:

  • Package JSON: more keywords apart from 'homebridge-plugin' should exist
  • Config Schema JSON: the pluginType is not set to 'platform'

🟢 The following checks passed:

  • Installation: successfully installed
  • Package JSON: homepage exists
  • Package JSON: bugs.url exists and seems a valid URL
  • Package JSON: engines.homebridge property is compatible with Homebridge 1.8.5
  • Package JSON: initializer function found
  • GitHub Repo: repository is public
  • GitHub Repo: repository is not archived
  • GitHub Repo: issues are enabled
  • GitHub Repo: contains releases
  • NPM Package: has not been deprecated
  • Config Schema JSON: exists and is valid JSON
  • Config Schema JSON: contains a valid pluginAlias
  • Config Schema JSON: contains a name schema property
  • Dependencies: homebridge was not installed as a dependency
  • Dependencies: hap-nodejs was not installed as a dependency

⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

These checks were run against v0.1.0 of the plugin.

@github-actions github-actions bot added awaiting-changes use after review has started - awaiting user to make changes to plugin and removed pending the label given to a new verification/icon request labels Dec 31, 2024
@YPyltiai
Copy link
Author

/check

@github-actions github-actions bot added pending the label given to a new verification/icon request and removed awaiting-changes use after review has started - awaiting user to make changes to plugin labels Dec 31, 2024
Copy link

🔴 The following checks failed:

  • Package JSON: more keywords apart from 'homebridge-plugin' should exist
  • Config Schema JSON: the pluginType is not set to 'platform'

🟢 The following checks passed:

  • Installation: successfully installed
  • Package JSON: homepage exists
  • Package JSON: bugs.url exists and seems a valid URL
  • Package JSON: engines.homebridge property is compatible with Homebridge 1.8.5
  • Package JSON: initializer function found
  • GitHub Repo: repository is public
  • GitHub Repo: repository is not archived
  • GitHub Repo: issues are enabled
  • GitHub Repo: contains releases
  • NPM Package: has not been deprecated
  • Config Schema JSON: exists and is valid JSON
  • Config Schema JSON: contains a valid pluginAlias
  • Config Schema JSON: contains a name schema property
  • Dependencies: homebridge was not installed as a dependency
  • Dependencies: hap-nodejs was not installed as a dependency

⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

These checks were run against v0.1.0 of the plugin.

@github-actions github-actions bot added awaiting-changes use after review has started - awaiting user to make changes to plugin and removed pending the label given to a new verification/icon request labels Dec 31, 2024
@YPyltiai
Copy link
Author

Added keywords https://github.com/YPyltiai/homebridge-dummy-cmd-switch/blob/main/package.json#L6 but didn't want to re-publish just for those alone.

Is it 100% required to be "Platform"? Given the narrow use case - wanted to keep it lightweight, so it has less configs and setup complexity. I don't expect it to grow way beyond the original use case explained in first comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-changes use after review has started - awaiting user to make changes to plugin request-verification
Projects
None yet
Development

No branches or pull requests

1 participant