Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

481 development of optimum strategy #500

Closed
wants to merge 17 commits into from

Conversation

InesHort
Copy link
Collaborator

@InesHort InesHort commented Jun 5, 2024

Hallo Alex,

ich möchte bitte, dass du ein Review von der Optimum Strategy Funktion(in PreTrainingStrategy.py) machst, ich versuche da die model_list zu holen aber ich weiß nicht ganz wie es am besten geht. Kannst du da mir bitte Hinweise geben und beziehungsweise mir sagen, ob die Funktion in die gute Richtung geht?

Viele Grüße
Ines

@InesHort InesHort requested a review from AlexanderZender June 5, 2024 09:41
@InesHort InesHort linked an issue Jun 5, 2024 that may be closed by this pull request
@AlexanderZender
Copy link
Collaborator

Hey,
Im waiting for your ok to review, so far i looked and i found this:

There are still different ports in H2O_SERVICE_PORT and changes in the launch and settings.json;
Missing comments;
Isnt the optimum strategy being moved to its own strategy class?

@InesHort InesHort force-pushed the 481-development-of-optimum-strategy branch from 67201a1 to bef60d2 Compare June 20, 2024 10:08
jamalissa and others added 9 commits June 20, 2024 21:24
Refactor and Document Code Enhancements

Changes include:
1. Renamed the "running" phase to "training" for clarity and consistency.
2. Added docstrings to newly implemented functions to enhance code readability and maintainability.
3. Implemented logic for comparing test scores
Refactor and Document Code Enhancements

Changes include:
1. Renamed the "running" phase to "training" for clarity and consistency.
2. Added docstrings to newly implemented functions to enhance code readability and maintainability.
3. Implemented logic for comparing test scores
implement the run interation function in the Evaluationstrategy class
@jamalissa jamalissa closed this Jul 12, 2024
@jamalissa jamalissa reopened this Jul 12, 2024
@InesHort InesHort closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Development of a trainings-strategy: Optimum-Strategy
3 participants