Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test-Script for umatching Iconclasses #48

Open
mauamy opened this issue Dec 17, 2020 · 1 comment
Open

Test-Script for umatching Iconclasses #48

mauamy opened this issue Dec 17, 2020 · 1 comment
Labels
backend Backend related stuff etl - transform Related to the transform step of the etl process medium priority

Comments

@mauamy
Copy link
Collaborator

mauamy commented Dec 17, 2020

Reason (Why?)
Some of the iconclasses in the XML source files does not match the iconclasses in the iconlass api.
For example the iconclass 98B(Nero)52 from the XML source file returns null. The correct one would be 98B(Nero)5(+2).

Solution (What?)
Since we can not fix this inside the XML source files, we should instead create a list of all iconclasses which are not correct (i.e. returning null). Therefor we can create a small script that runs (independently?) from the ETL process and tries to request all parsed iconclasses from the iconclass api. Every iconclass that returns null should than be written into a list / file.

Acceptance criteria
A script tests all iconclasses and outputs a list of all wrong (i.e. returned null) entries.

@mauamy mauamy added the backend Backend related stuff label Dec 17, 2020
@mauamy mauamy assigned mauamy and unassigned mauamy Dec 17, 2020
@EeveesEyes EeveesEyes added the etl - transform Related to the transform step of the etl process label Dec 17, 2020
@mauamy mauamy added this to the Pre-Release milestone Dec 17, 2020
@BernhardHumm
Copy link
Member

BernhardHumm commented Dec 17, 2020 via email

@mauamy mauamy removed their assignment Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related stuff etl - transform Related to the transform step of the etl process medium priority
Projects
None yet
Development

No branches or pull requests

3 participants