Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller.py -- populate_docs_entities #1

Open
arpie71 opened this issue Apr 23, 2018 · 4 comments
Open

controller.py -- populate_docs_entities #1

arpie71 opened this issue Apr 23, 2018 · 4 comments

Comments

@arpie71
Copy link
Collaborator

arpie71 commented Apr 23, 2018

The function calls for an SQL query for countries, persons, and topics. Retrieving all (country_list = q.all(), for example) breaks the function. If this is changed to a limit, the function works.

@mnyrop
Copy link
Contributor

mnyrop commented Sep 26, 2018

Is this fixed? If so, can you link to specific line numbers and I'll commit the changes with context?

@arpie71
Copy link
Collaborator Author

arpie71 commented Sep 26, 2018

It's fixed on my branch. The line numbers in your controller.py file are 212, 227, and 241.

@mnyrop
Copy link
Contributor

mnyrop commented Sep 27, 2018

What if the API query has more than 1000 results? Isn't the limit arbitrary/inaccurate?

@arpie71
Copy link
Collaborator Author

arpie71 commented Sep 27, 2018

That's a fair point, but right now the populate_docs_entities only calls the topics, persons, and countries databases. Topics and countries have fewer than 1000 entries and persons does now as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants