-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve masked emoji appearence #473
Comments
Hi @sotha1, many thanks! Good call, yes your suggestions would definitely improve it, especially as other OpenMojis with masks eg. https://openmoji.org/library/emoji-E0AC-200D-2642-FE0F/ have a style like the one you suggested. Could you go ahead and grab the src file and edit/improve it? :) |
do you mean 'svg' with 'src'? if yep, of course, its on my way |
Great! Here is some hyper specific feedback :) If we re-do the OpenMoji it would be nice to be really 100%. I hope you don't mind!
OK? Please make sure to submit then the final file tested (-> https://openmoji-tester.glitch.me/) and a src svg which has the grid layer in it. |
Hi @sotha1, great improvements! No further comments :) Either do a pull request or upload the src file in this chat, please test the file beforehand with the https://openmoji-tester.glitch.me/. Cheers! |
hey, i found these errors: do you know how to fix they? |
@sotha1 this is hard to debug from remote :) Hence please use the original source file and copy your changes over. Please see also https://openmoji.org/styleguide/ and especially https://openmoji.org/styleguide/#submission I hope this helps. |
Open the SVG and check that all elements e.g. rect, line, circle ... don't have any style attribute e.g. remove all |
I think the masked emoji can be confused with a smile or something else, it's a bit subjective, but here's my suggestion:
here's the original:
and my one:
i know that it's a weird drawing but that's a exemple of the emoji should look on my idea
The text was updated successfully, but these errors were encountered: