Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goblin support cross default wotlk client. #6

Open
Helias opened this issue Mar 6, 2022 · 9 comments
Open

Goblin support cross default wotlk client. #6

Helias opened this issue Mar 6, 2022 · 9 comments
Labels
enhancement New feature or request

Comments

@Helias
Copy link
Collaborator

Helias commented Mar 6, 2022

I made some experiments in past about a possible mod-race-goblin where:

  • the server-side DBCs have some little changes and support for the goblin race
  • we have two kind of clients:
    • client where you can create a goblin using a default skin
    • default client wotlk 3.3.5a already support the "goblin" race through DBC

GOAL: create an "optional goblin race" where the players can choose to download the goblin patch and create a goblin race or just ignore it and use the default wotlk 3.3.5a client BUT still be compatible with the custom client "goblin client" with the race and see the goblin race without any issues.

CONs:

  • limitations for the goblin race about animations, skin and models/equipment

PROs:

  • you don't need to download a custom patch if you do not want to create a goblin

With a launcher this experiments are not really useful because you "solve" the issue that the players that does not want the goblin don't need to download the patch (because the launcher would download it anyway).

Hope this is interesting for you.

@heyitsbench heyitsbench added the enhancement New feature or request label May 23, 2022
@yuanf225
Copy link

This has to modify the conditions of the dbc and the quest creature for it to work

@Helias
Copy link
Collaborator Author

Helias commented May 30, 2022

it's hard that this can work, but we can do a try if we have time for it

@heyitsbench
Copy link
Owner

heyitsbench commented Jun 23, 2022

Okay so theoretically this is very possible.
image
Screenshot taken from a clean Wow enUS client.

About that con though:

limitations for the goblin race about animations, skin and models/equipment

Because goblins were intended to be a character race, Blizzard made all the typical animations you'd expect of a character as well as all the models necessary for them to wear helmets and such. (EDIT: Don't know if they kept up with necessary TBC/WotLK animations, but most other animations were created) Some of the comfort features I've added might be possible to add, such as mounts/achievements, and racial spells might not cause issues seeing as the clean client just cares about what the server is saying, e.g. mounting up on the trike doesn't show any mount for the clean client, nor the aura saying the goblin player is mounted.

@Helias
Copy link
Collaborator Author

Helias commented Jun 24, 2022

Wonderful! Of course, specific animations or face changes cannot be ported, but this is very great.
We could do a mod-race-goblin that does not require any client changes to view the goblin race (it requires patch only if you want to create the goblin char).

Very good job man!

@heyitsbench
Copy link
Owner

Question on this: Assuming any and all custom work will not crash a clean client, should achievements/racials/mounts be included in such a version?

@Helias
Copy link
Collaborator Author

Helias commented Jul 7, 2022

custom mounts no, because to add them you need to force the other clean clients to download a patch
"normal" mounts ofc, the goblin should be able to use a mount

not sure if achievements require a custom patch also for others client, I would like to keep it as minimal as possible

@heyitsbench
Copy link
Owner

The only achievements I can see being possible to add with this would be the realm first 80 achievements, as modifying the existing achievements to accommodate goblins isn't feasible. As for the mounts, the clean client isn't forced to download a patch, it just doesn't show the mount for the client, as in the screenshot in #6 (comment), the goblin is on a custom trike mount. However, I do agree with you that they should probably just stick with existing mounts so as to not cause confusion for clean client users. I will do some testing to see how clean clients display the various racial abilities I've added to see if those would be feasible.

@Helias
Copy link
Collaborator Author

Helias commented Jul 7, 2022

keep it as minimal as possible, adding a race it's already a big change imho

@heyitsbench
Copy link
Owner

heyitsbench commented Jul 7, 2022

Okay, I've got it in what I'd call a decent working state in this branch: https://github.com/benjymansy123/mod-worgoblin/tree/optional-goblin. Still a bunch of references to worgen in the DBCs I've got to get rid of, I've likely gotta adjust the SQL for items/quests, and there seems to be a customization issue I need to resolve, but it is working.

Oh yea, there's also a GlueXML issue I made. Whoops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants