Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Add Death Knight Starting Zone Quests #38

Open
heyitsbench opened this issue Oct 4, 2022 · 4 comments
Open

TODO: Add Death Knight Starting Zone Quests #38

heyitsbench opened this issue Oct 4, 2022 · 4 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@heyitsbench
Copy link
Owner

Gotta get em workin for @acidmanifesto 😄

@heyitsbench heyitsbench added bug Something isn't working enhancement New feature or request labels Oct 4, 2022
@acidmanifesto
Copy link

Really the one special quest dealing with worgen and goblin is that one questline where u murder the friend at the chapel.

@heyitsbench
Copy link
Owner Author

That's what I thought, still needs implementing.

@heyitsbench
Copy link
Owner Author

Looks like this requires adding to the .patch file, as that particular quest seems to be handled at least partially in the core.

@heyitsbench
Copy link
Owner Author

bool MeetQuestCondition(Player* player)
{
    switch (me->GetEntry())
    {
        case 29061:                                     // Ellen Stanbridge
            if (player->GetQuestStatus(12742) == QUEST_STATUS_INCOMPLETE)
                return true;
            break;
        case 29072:                                     // Kug Ironjaw
            if (player->GetQuestStatus(12748) == QUEST_STATUS_INCOMPLETE)
                return true;
            break;
        case 29067:                                     // Donovan Pulfrost
            if (player->GetQuestStatus(12744) == QUEST_STATUS_INCOMPLETE)
                return true;
            break;
        case 29065:                                     // Yazmina Oakenthorn
            if (player->GetQuestStatus(12743) == QUEST_STATUS_INCOMPLETE)
                return true;
            break;
        case 29071:                                     // Antoine Brack
            if (player->GetQuestStatus(12750) == QUEST_STATUS_INCOMPLETE)
                return true;
            break;
        case 29032:                                     // Malar Bravehorn
            if (player->GetQuestStatus(12739) == QUEST_STATUS_INCOMPLETE)
                return true;
            break;
        case 29068:                                     // Goby Blastenheimer
            if (player->GetQuestStatus(12745) == QUEST_STATUS_INCOMPLETE)
                return true;
            break;
        case 29073:                                     // Iggy Darktusk
            if (player->GetQuestStatus(12749) == QUEST_STATUS_INCOMPLETE)
                return true;
            break;
        case 29074:                                     // Lady Eonys
            if (player->GetQuestStatus(12747) == QUEST_STATUS_INCOMPLETE)
                return true;
            break;
        case 29070:                                     // Valok the Righteous
            if (player->GetQuestStatus(12746) == QUEST_STATUS_INCOMPLETE)
                return true;
            break;
//      case 49355:                                     // Lord Harford
//          if (player->GetQuestStatus(28649) == QUEST_STATUS_INCOMPLETE)
//              return true;
//          break;
//      case 49356:                                     // Gally Lumpstain
//          if (player->GetQuestStatus(28650) == QUEST_STATUS_INCOMPLETE)
//              return true;
//          break;
    }

    return false;
}

These are the lines that need changing in the scarlet enclave script. I will add the changes to the patch file once this PR gets merged, otherwise all the rest of the changes required for this are all done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants