Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on_error could benefit from providing more context #860

Open
colincasey opened this issue Sep 10, 2024 · 1 comment
Open

on_error could benefit from providing more context #860

colincasey opened this issue Sep 10, 2024 · 1 comment
Labels
enhancement New feature or request libcnb

Comments

@colincasey
Copy link
Contributor

The signature of the error handler for a Buildpack impl is:

fn on_error(&self, error: libcnb::Error<Self::Error>)

When it comes to reporting errors I find myself having to duplicate useful information such as the buildpack name, version, homepage, etc. It would be preferable if the framework could provide a bit more context in the libcnb::Error::BuildpackError variant such as:

  • the serialized buildpack descriptor
  • the target architecture
  • the app directory
@colincasey colincasey added the enhancement New feature or request label Sep 10, 2024
@Malax
Copy link
Member

Malax commented Sep 16, 2024

Sounds very reasonable to me! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request libcnb
Projects
None yet
Development

No branches or pull requests

3 participants