Add test coverage of compound bash commands #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Procfile` format supports specifying compound bash commands like: ``` web: foo && bar ``` This buildpack currently supports these, however, there is no integration test coverage of them. Having coverage is important, since some of the approaches for implementing the `bash -c` wrapping don't support usage of compound commands, as seen in: #150 (comment) This test case was extracted from #150 (which itself was superseded). As such I've added a new integration test for this, which also tests quoting (in case a future buildpack implementation starts trying to parse/escape the commands) and variable interpolation.
colincasey
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Procfileformat supports specifying compound bash commands like:This buildpack currently supports these, however, there is no integration test coverage of them.
Having coverage is important, since some of the approaches for implementing the
bash -cwrapping don't support usage of compound commands, as seen in:#150 (comment)
As such I've added a new integration test for this, which also tests quoting (in case a future buildpack implementation starts trying to parse/escape the commands) and variable interpolation.
This test case was extracted from #150 (which itself was superseded).
GUS-W-16148705.