Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path as a parameter to herbs update and herbs spec #171

Open
vitorgamer58 opened this issue Nov 23, 2022 · 0 comments
Open

Path as a parameter to herbs update and herbs spec #171

vitorgamer58 opened this issue Nov 23, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@vitorgamer58
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Herbs update and herbs spec commands must receive an optional parameter, enabling the test folder to be changed.

Describe the solution you'd like
As described in #170 (comment), the commands must receive a parameter to change the default folder.

Describe alternatives you've considered
I considered changing the default folders in herbarium.requireAll() as well as in herbs new, changing all the templates, in effect implementing a kind of breaking change.

However, the change was denied in: #170

Additional context
herbsjs/herbarium#6
@vitorgamer58 vitorgamer58 added the enhancement New feature or request label Nov 23, 2022
vitorgamer58 added a commit to vitorgamer58/herbs-cli that referenced this issue Nov 23, 2022
@vitorgamer58
feat(utils.js): requireHerbarium must be able to receive options
483e3ca 
Options passed to requireHerbarium must be passed to herbarium.requireAll, enabling custom paths.

herbsjs#171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vitorgamer58