Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Herbs generated project must to born with lint #14

Open
italojs opened this issue Aug 19, 2021 · 12 comments
Open

Herbs generated project must to born with lint #14

italojs opened this issue Aug 19, 2021 · 12 comments
Assignees
Labels
enhancement New feature or request hacktoberfest ready-to-work Item is ready to work on it severity-minor Item is not urgent wip work in progress

Comments

@italojs
Copy link
Member

italojs commented Aug 19, 2021

I was thinking to have an option to add esLint into project

> Do you wanna use lint ? [y/N] y
- esLint
- tsLint
- jsHint

> What code style do you prefer to use?
- standard
- google
- airbnb

To start this feature, I was thinking to use only standard code style

@italojs italojs added the enhancement New feature or request label Aug 19, 2021
@dalssoft
Copy link
Member

if you choose one style, the generated code will follow?

@maikvortx
Copy link

Hi! We can start with one of the options. What do you think we started with eslint using the Vortx One Manager config as default. About the google and airbnb options, we can use the configuration of these packages, respectively, https://github.com/google/eslint-config-google and https://www.npmjs.com/package/eslint-config-airbnb .

@italojs
Copy link
Member Author

italojs commented Oct 12, 2021

I like to start with a default linter, but I prefer the standard JS because it's the standard, this style guide is the more neutral, some developer don't like the airbnb style guide or google style guide but I think the most developers will accept the standardJS because it's neutral

@dalssoft
Copy link
Member

As long we choose one and the user don't have to choose, I don't really care. The choice will always be wrong since there will be always someone complaining, so let's pick one.

standard JS sounds ok to me.

@italojs italojs mentioned this issue Nov 21, 2021
4 tasks
@jhomarolo jhomarolo added ready-to-work Item is ready to work on it severity-minor Item is not urgent and removed ready2implement labels Dec 22, 2021
@italojs italojs added the wip work in progress label May 13, 2022
@italojs
Copy link
Member Author

italojs commented May 13, 2022

I'm working on it

@dalssoft dalssoft moved this to More discussion is needed in Herbs - 3rd Anniversary Edition Jun 27, 2022
@dalssoft dalssoft moved this from More discussion is needed to Ready to code in Herbs - 3rd Anniversary Edition Jun 27, 2022
@maikmb
Copy link

maikmb commented Jul 5, 2022

Standard JS sounds good for me too!

@jhomarolo
Copy link
Contributor

@italojs are you still here with this issue?

@italojs
Copy link
Member Author

italojs commented Jul 11, 2022

Hi @jhomarolo i'm not working on this anymore

@mtperesvx
Copy link
Contributor

I can work on this issue.

@dalssoft
Copy link
Member

Given the inputs on this issue, this is how I think this feature should work:

  • Generate and specify the StandardJS by default on lint file
  • Add a script action on npm to run lint on everyfile of the project.
  • This script to lint all files should run after herbs new. This is important since the current file templates does not respect any lint or even worse (some are a real mess) and the generated file doesn't look good.

@jhomarolo
Copy link
Contributor

@dalssoft I guess should be good to run the script (like npm run lint or lint:fix) after herbs update as well

https://github.com/herbsjs/todolist-on-herbs/blob/97c541a05c7530c769b772d650db6ff19ec2a94a/package.json#L16

@dalssoft
Copy link
Member

@jhomarolo makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest ready-to-work Item is ready to work on it severity-minor Item is not urgent wip work in progress
Projects
Status: Ready to code
Development

No branches or pull requests

6 participants