Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer commands are typable commands only, not also static commands #12736

Open
Diablo-D3 opened this issue Jan 31, 2025 · 3 comments
Open

Buffer commands are typable commands only, not also static commands #12736

Diablo-D3 opened this issue Jan 31, 2025 · 3 comments
Labels
C-enhancement Category: Improvements

Comments

@Diablo-D3
Copy link

:buffer-close, :buffer-next, :buffer-prev, and the rest only exist as typable commands, but commands like wclose exist as static commands.

This makes it awkward as I have to type, for example, :bclose to bind it to a key. This also has the side effect of not automatically filling in the doc string in <space>?.

@Diablo-D3 Diablo-D3 added the C-enhancement Category: Improvements label Jan 31, 2025
@the-mikedavis
Copy link
Member

This makes it awkward as I have to type, for example, :bclose to bind it to a key. This also has the side effect of not automatically filling in the doc string in <space>?.

I don't understand these points - you can bind typable commands to keys like static commands:

[keys.normal]
C-x = ":buffer-close"

and I see the binding for C-x in the command palette show :buffer-close's doc

@Diablo-D3
Copy link
Author

I misspoke. <spc>? works, the which-key popup doesn't.

Image

@the-mikedavis
Copy link
Member

the-mikedavis commented Feb 1, 2025

Ah, I think we can fix that - it would be better to show the typed command's docs instead of what would be executed when it's a single command that doesn't take any arguments. I would prefer to improve that display (and any other rough edges of typed commands) rather than introduce duplicate static commands.

I have added e9c16b7 which makes that change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

2 participants