Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 Some slides can't use code editor, others do, depending on the page language #6123

Open
yilmazdurmaz opened this issue Jan 22, 2025 · 4 comments
Labels
bug Something isn't working

Comments

@yilmazdurmaz
Copy link
Contributor

yilmazdurmaz commented Jan 22, 2025

Describe the bug
I am currently checking my translations in slides and testing if program fragments have any issues.

The problem is in the use of the code editor in slides. Starting from level 3 slides, the editor panel gives 404 error.

This happens in 1 situation out of 3 possible states:

  • O - users can see the editor if they are logged in
  • O - users can see the editor if the page keyword language is English, even if they are not logged in
  • X - the editor part gives 404 error if the user is not logged in AND page keyword language is not English

EDIT: I checked again and see being logged in is not related directly. I missed I last changed my keyword language to English while trying to check other changes in my translations

I prefer being able to access to the editor in slides in my language and without logging in, as it is useful to use slides in temporary environments. Considering it can still be used without logging in just by setting the language to English suggests me the security is not a concern here.

However, if you choose to require a logged in user, then you should also fix this for English language. In that case, just check the slides with the numbers other than the ones I listed below.

Please check the issue and fix the problem.
YILMAZ

Paste the Hedy code & level

Editor is giving 404 error in slides of these levels:

  • 3
  • 5
  • 7
  • 9 to 17

Steps to check the issue:

(use page language switcher if you are not logged in, and keyword language switcher if you are logged in. both works the same and gives 404 if language is not English)

Add a screenshot (optional)

screencast-hedy.org-2025.01.22-15_00_20.webm
screencast-hedy-alpha.herokuapp.com-2025.01.22-20_56_12.webm

What machine and browser you were using (optional)
Windows 10, MS Edge

@yilmazdurmaz yilmazdurmaz added the bug Something isn't working label Jan 22, 2025
@yilmazdurmaz yilmazdurmaz changed the title 🪲 Some slides can't use code editor, others do, depending on the page language and user status 🪲 Some slides can't use code editor, others do, depending on the page language Jan 22, 2025
@yilmazdurmaz
Copy link
Contributor Author

I checked again and see being logged in is not related directly. I missed I last changed my keyword language few daya ago to English while trying to check other changes in my translations

I made necessary edits in above post. I am writing here to ping if someone has noticed, interested but did not have time to interact.

@yilmazdurmaz
Copy link
Contributor Author

There is another aspect I have found out: regardless of page/keyword language being English, "Let's debug" sections in slides listed above give 404 error.

EDIT: in addition to debug pages, same issue occurs in slide 8 page 4. here, indentation is introduced, and the code for this page is not using indentation.

I think this one I mention is another bug about showing buggy code, but it is also interesting because slides for level 1 and 2 can show "Let's debug" pages. This aspect might require its own issue post.

@boryanagoncharenko
Copy link
Collaborator

boryanagoncharenko commented Jan 29, 2025

@AnneliesVlaar @MarleenGilsing I am adding a summary, so that can prioritize accordingly. This is a combo of 2 separate issues:

The keyword language makes the code editor in slides fail, but only sometimes

Steps to reproduce for anonymous users:

  • Open hedy.org and do not log in. Select Spanish as the language.
  • Navigate to hedy.org/slides/3 and go to a slide that has an editor. You should see an error
  • Go to hedy.org/slides/2, navigate to a slide with an editor and use the green button in the top right corder (right above the editor) to change the keyword language from Spanish to English
  • Navigate back to hedy.org/slides/3 and now the editor should display the program correctly

Steps to reproduce for logged-in users:

  • Open hedy.org and log in. Set the language of the profile to Serbian and the keyword language to English.
  • Navigate to hedy.org/slides/3 and go to a slide that has an editor. The editor should be displayed correctly
  • Change the keyword language from English to Serbian using the green button in the upper right corner, right above the slide editor. Now you should see an error. (The same result could be achieved if you change the keyword language in your profile and then navigate to hedy.org/slides/3)

Note that this does not happen for the slides of all levels OR for all languages. As pointed out, only levels 3, 5, 7, 9-17 fail. Also, I noticed that Dutch and German seem to be working, but Turkish, Bulgarian, Serbian, Spanish and Esperanto are failing.

The debug slide fails to load the editor

This is a combination of content issues with the slides and code problems that need to be resolved.

@AnneliesVlaar
Copy link
Collaborator

@boryanagoncharenko for me there is also an error in German in slides of level 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Planned
Development

No branches or pull requests

3 participants