Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📜highlight styles for <code> tag is missing in slides (highlighting keywords in text) #6117

Open
yilmazdurmaz opened this issue Jan 21, 2025 · 1 comment
Labels
content issues related to adventure tabs enhancement New feature or request

Comments

@yilmazdurmaz
Copy link
Contributor

Describe the issue

This happens in slides for English and Turkish at least.

I could not yet check them all, but they should be sharing a single style in the template, so I expect this in all slides.

The following from "build-tools/heroku/tailwind/styles.css", for example, could solve the problem if added in the template.

code {
  @apply font-mono inline rounded py-1 px-2 font-normal;
  background: #272822 !important;
  color: #ff6188;
  font-size: 90%;
}

For the moment, I am adding a visual indicator to my translations. that is, I am quoting keywords like this "{print}". Ugly in the source but looks good on the page. Also, it will still be looking nice if you fix the highlighting.

Below, I added screenshots of current and expected looks of keywords in slides.

Add a screenshot (optional)

Image

Image

Expected text

Image

Temporary solution
Image

@yilmazdurmaz yilmazdurmaz added the content issues related to adventure tabs label Jan 21, 2025
@boryanagoncharenko
Copy link
Collaborator

boryanagoncharenko commented Jan 29, 2025

@AnneliesVlaar @MarleenGilsing I am posting a summary for you. On the hedy website, if a keyword (or a code fragment) is used in a text, it is styled in a nice way to illustrate it is code. This happens in the level text of the code page, in the error messages displayed by the code editor, and in the custom adventure editor we have the <> button to style the code-in-text accordingly. This is how the styling looks like: Image

So, this works everywhere but not in the slides. In slides, keywords/code fragments use a different font but not the nice pink-on-black styling. This issue requests the style of the keywords/code fragments in slides to be the same as the rest of Hedy.

Please bear in mind that slides probably never styled keywords properly, or at least they did not in the past year. So, this could be considered as more of a feature request than a bug.

@AnneliesVlaar AnneliesVlaar added the enhancement New feature or request label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content issues related to adventure tabs enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

3 participants