Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend: Refactor headlamp.go refreshAndCacheNewToken to be shorter #1848

Open
1 task
illume opened this issue Mar 22, 2024 · 2 comments · May be fixed by #2816
Open
1 task

backend: Refactor headlamp.go refreshAndCacheNewToken to be shorter #1848

illume opened this issue Mar 22, 2024 · 2 comments · May be fixed by #2816
Labels
backend Issues related to the backend good first issue Good for newcomers quality Related to improving the quality of the app

Comments

@illume
Copy link
Collaborator

illume commented Mar 22, 2024

This function needs to be shorter to reduce the complexity of it, and make it easier to understand. Perhaps it should be 2 or more functions.

Currently the code turns off the linter for this issue with "//nolint:funlen".

  • refactor the code to make the function short and easier to understand
  • See quick start contributing guide on how to get started.
  • See backend/cmd/headlamp.go file.
  • See backend contributing guide
  • To run the linter, make backend-lint
  • How to run tests: make backend-test



Related umbrella backend refactoring clean up issue #855 (other pieces of code have the linter disabled and could also be fixed up, feel free to refactor a different function.)
@illume illume added good first issue Good for newcomers backend Issues related to the backend quality Related to improving the quality of the app labels Mar 22, 2024
@CroWzblooD
Copy link

Is it still availabl,e I would like to give a try

@guipguia guipguia mentioned this issue Jul 28, 2024
Merged
@EshaanAgg
Copy link

Hi! Is this issue open for contribution? I would love to give it a short?

@Faakhir30 Faakhir30 linked a pull request Jan 30, 2025 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Issues related to the backend good first issue Good for newcomers quality Related to improving the quality of the app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

backend: refactor: refreshAndCacheNewToken in headlamp.go Faakhir30/headlamp
3 participants
@illume @CroWzblooD @EshaanAgg