Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] main @ 5a4749c : pink analog render, sometimes green #468

Open
nerdCopter opened this issue Dec 16, 2024 · 2 comments
Open

[bug] main @ 5a4749c : pink analog render, sometimes green #468

nerdCopter opened this issue Dec 16, 2024 · 2 comments

Comments

@nerdCopter
Copy link
Contributor

nerdCopter commented Dec 16, 2024

in regard to Analog / RapidFire, commit 4e963ad is much more stable than main(master). I did not bisect, but i believe one or more of PR #460, #461, #462 may have messed it up.

Receiving pink analog again, and sometimes worse (green).

hdz_0015
hdz_0016
hdz_0015.ts.zip
hdz_0016.ts.zip

where 4e963ad is dated Nov 21, and the failure is in latest commit. Again, I did not bisect interim commits.

5a4749c Ligen   2024-12-10  Merge pull request #464 from Master92/formatRecalc
484c897 Ligen   2024-12-10  Merge pull request #466 from ligenxxxx/disable-tp2825-color-killer
01b78a2 Ligen   2024-12-10  enable color killer
2714609 Master92    2024-11-11  Update free SD card space after format
c224c17 Ligen   2024-11-29  Merge pull request #462 from ligenxxxx/fix-topy
0b0576d ligenxxxx   2024-11-29  fix topy
ac6ea86 Ligen   2024-11-28  Merge pull request #461 from ligenxxxx/force-av-in-clock-phase
6f04bcf ligenxxxx   2024-11-28  Update TP2825.c
9267eb0 Ligen   2024-11-28  Merge pull request #460 from ligenxxxx/force-av-in-clock-phase
9e581ea ligenxxxx   2024-11-28  force av in clock phase
a0dbbe4 Ligen   2024-11-23  Update VERSION to 9.5.0-rc1
4e963ad Ligen   2024-11-21  Merge pull request #459 from Master92/compile_warnings
@nerdCopter
Copy link
Contributor Author

nerdCopter commented Dec 31, 2024

@ligenxxxx , the provided HDZERO_GOGGLE-75-200-9.4.0-24b61aa.bin had no pink -- no-pink in Analog video and no-pink in Rapidfire Menu; However, the analog video was stretched to 16:9 instead of the expected 540p 4:3.

edit: screenshot
image

edit: i'm reverting to 4e963ad for the time-being, but it has pink in the rapidfire-menu (only).
image

@nerdCopter
Copy link
Contributor Author

nerdCopter commented Jan 13, 2025

@ligenxxxx , Any more testing needed? will the fix get PR'd to main?
Also noting that the analog is stretched, will such be made optional to resolve ##145 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant