Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fix support to lobid ressources #1345

Closed
TobiasNx opened this issue Jun 7, 2022 · 1 comment
Closed

Add fix support to lobid ressources #1345

TobiasNx opened this issue Jun 7, 2022 · 1 comment
Assignees
@TobiasNx
Labels
ALMA

Comments

@TobiasNx
Copy link
Contributor

TobiasNx commented Jun 7, 2022

At the moment it seems that only morph is supported. To move ALMA transformation to Metafix #1341. We need support for Metafix in lobid-ressources.
@TobiasNx TobiasNx added the ALMA label Jun 7, 2022
@TobiasNx TobiasNx mentioned this issue Jun 10, 2022
Closed
10 tasks
dr0i added a commit that referenced this issue Jun 13, 2022
@dr0i
Enable metafix (#1345)
4172bfe 
Provides an example of Alma Marc XML ETL (based on the input used by morph ETL).
Prerequisites:
install metafix locally;
- checkout https://github.com/metafacture/metafacture-fix.git
- change to that directory
- `./gradlew publishToMavenLocal`
This installs metafix to a local maven repo in: '~/.m2/repository/org/metafacture/metafix/'
The version 0.3.0-SNAPSHOT is needed.
- change directory to lobid-resources
Run like:
'mvn clean install -DskipTests=true ; mvn -DgenerateTestData=true failsafe:integration-test -Dit.test=AlmaMarc21XmlToLobidJsonMetafixTest.java'.
@dr0i dr0i mentioned this issue Jun 13, 2022
Merged
@dr0i
Copy link
Member

dr0i commented Jun 13, 2022

#1347 should enable metafix. A first example of ETL with alma-fix is provided there, also how to use it. the fix are taken from https://github.com/hbz/limetrans/tree/wip/src/main/resources/transformation.
There will be many things not correct yet, e.g. fix variables set in AlmaMarc21XmlToLobidJsonMetafixTest.java - we will work that out.

@dr0i dr0i assigned TobiasNx and unassigned dr0i Jun 13, 2022
TobiasNx added a commit that referenced this issue Jun 14, 2022
@TobiasNx
Switch the first morph to fix (#1345)
2b7aa17
TobiasNx added a commit that referenced this issue Jun 15, 2022
@TobiasNx
Fix id #1345
a124390
TobiasNx added a commit that referenced this issue Jun 17, 2022
@TobiasNx
Fix id #1345
88268dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TobiasNx TobiasNx

Labels
ALMA
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dr0i @TobiasNx