Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have better support for removing and adding control from Visual Tree #23

Open
hawkerm opened this issue Jul 23, 2018 · 0 comments
Open

Comments

@hawkerm
Copy link
Owner

hawkerm commented Jul 23, 2018

To curb memory usage, we try and remove all handles in the Unloaded event, as we don't know if that's because we're removed from VisualTree temporarily or for good.

In the case we get re-added to the VisualTree, then we need to reload all the handles and things that were removed. In v0.7, we made this work better for the editor itself so things wouldn't be unstable. But for things which require events and callbacks, there's some things which aren't getting rehooked back up properly still.

Not sure if this is a limitation of AddWebAllowedObject or something else. If we can eventually save state, then we could just deconstruct the webview, reconstruct everything on load again and restore state...

See Monaco Issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant