Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Support thresholds for bar charts #28

Open
Hamsterbau opened this issue Mar 21, 2018 · 0 comments
Open

Bugfix: Support thresholds for bar charts #28

Hamsterbau opened this issue Mar 21, 2018 · 0 comments

Comments

@Hamsterbau
Copy link

Like mentioned in the documentation, threshold plugin should also work for bar charts. But currently plugins are only usable for line charts because of missing support for plugins in bar chart.

LineRenderer.java:

if (chart.getPlugins() != null) {
	writer.write(",plugins:" + chart.getPlugins());
}

BarRenderer.java:

No part for handling plugins.

Fix should be easy, just add the lines from LineRenderer.java to BarRenderer.java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant