Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to include "extra settings" #648

Open
michaelpj opened this issue Jul 18, 2022 · 4 comments
Open

Add a way to include "extra settings" #648

michaelpj opened this issue Jul 18, 2022 · 4 comments
Labels
type: enhancement An enhancement to an already existing feature

Comments

@michaelpj
Copy link
Contributor

When working on a new HLS feature, it is common to want to add some settings. Ideally, these eventually are exposed as proper settings in the extension, but when hacking on it it would be nice to have a way to toggle your new settings without having to edit the extension.

I suggest we could have something like an unstructured "extra-settings" bag, which will just get added in before sending to the server. I'm not sure whether there's an appropriate way to do this in vscode, though.

@hasufell hasufell added the type: enhancement An enhancement to an already existing feature label Jul 18, 2022
@July541
Copy link
Collaborator

July541 commented Jul 10, 2023

If I remember correctly, while working on hls-class-plugin, I can add extra settings directly as normal settings in settings.json.

@fendor
Copy link
Collaborator

fendor commented Jul 10, 2023

Right, but there is no general way to specify arguments that are sent to HLS directly.

The suggestion is basically to have a haskell.genericConfig field which takes a json object. These options are sent as part of the initialisation request.

For example, imagine hls-cabal-plugin has some config that we haven't specified in vscode-haskell

"haskell.plugin.cabal.globalOn": {
. There is currently no way to specify any options the vscode extension doesn't know about, right?

@July541
Copy link
Collaborator

July541 commented Jul 10, 2023

Sorry for confusing you, I mean I can(not entirely certain) add this to settings.json before the package.json has this field.

"haskell.plugin.class.codeLensOn": {

@fendor
Copy link
Collaborator

fendor commented Jul 10, 2023

Really? That's great, we should advertise it then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement An enhancement to an already existing feature
Projects
None yet
Development

No branches or pull requests

4 participants