Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mispellings across code #1116

Open
Benjamin-McRae-Tracsis opened this issue Sep 6, 2024 · 4 comments
Open

Mispellings across code #1116

Benjamin-McRae-Tracsis opened this issue Sep 6, 2024 · 4 comments

Comments

@Benjamin-McRae-Tracsis
Copy link

unespected is a spelling error in at least 4 places I can see, plus tests.

Here is an example: https://github.com/haskell/aeson/blob/c93d60d82388c184a9cf240f016a728c9d0e758f/src/Data/Aeson/Decoding/ByteString.hs#L164C19-L164C29

It would be good to remove such spelling errors.

@ad-si
Copy link

ad-si commented Sep 12, 2024

You could use https://github.com/crate-ci/typos. It works surprisingly well!

@dhruvdabhi101
Copy link

Hey, i would like to work on this if it is open to work.

@L0neGamer
Copy link

Looks like someone was fixing it in #1081 before I even made this issue. I assume that @phadej would prefer to merge that than make a new PR.

@phadej
Copy link
Collaborator

phadej commented Jan 26, 2025

Yes, but we are careful not to change error messages in minor releases, as something (usually tests) may break somewhere. But alone spelling errors don't justify a major release, so I'm stalling on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants