Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting text in Features unexpands the expandable texts. #54

Open
arianvp opened this issue Feb 15, 2015 · 2 comments
Open

Selecting text in Features unexpands the expandable texts. #54

arianvp opened this issue Feb 15, 2015 · 2 comments

Comments

@arianvp
Copy link

arianvp commented Feb 15, 2015

Expected behaviour:

I click on concurrency. The text expands. I select the code snippet that I want to copy (to try it out). I paste the code snippet in my editor.

Current behaviour:
I click on concurrency. The text expands. I select the code snippet. I let the mouse button go and I want to hit CTRL+C. But before I can do that the text unexpands and gets deselected, making it impossible to copy the code snippet.

I'll see if I can make a quick fix for this tonight.

@arianvp
Copy link
Author

arianvp commented Feb 15, 2015

I hope everyone agrees this behaviour is unwanted. But how do we want the behaviour to be?

I think making the whole thing clickable to expand it is good for discover-ability so lets keep that in. But lets remove the "make the whole thing clickable to collapse" part.

I was thinking of making a simple 'click to collapse' link which has to be clicked to collapse it again. Or make a clickable bar at the bottom of a collapsible item.

@chrisdone
Copy link
Member

I don't consider this a significant problem. It has a workaround: On both Firefox and Chrome I can just hold down the mouse to copy/paste.

I'll happily accept a patch that disables expanding when selection is made, e.g. like this. In contrast, "click to collapse" removes the symmetry of clicking and clicking again to collapse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants