Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpp-options for Windows need an update again (probably) to fix our broken CI #280

Open
Mikolaj opened this issue Feb 14, 2023 · 2 comments

Comments

@Mikolaj
Copy link
Contributor

Mikolaj commented Feb 14, 2023

This line

https://github.com/haskell-game/sdl2/blame/master/sdl2.cabal#L168

was written twice already and perhaps it needs another tweak to work, because otherwise we get in https://github.com/haskell-game/sdl2/actions/runs/3732668333/jobs/6332423036#step:9:21

Missing (or bad) C libraries: SDL2, SDL2main, SDL2

I wonder if something like

cpp-options: -D_SDL_main_h -DSDL_main_h_ -DSDLmain_h_

would do the trick, but I can't easily check, because

~/r/sdl2$ git push --set-upstream origin mikolaj/tweak-windows-cpp-options
ERROR: Permission to haskell-game/sdl2.git denied to Mikolaj.
fatal: Could not read from remote repository.

Halp!

@Mikolaj
Copy link
Contributor Author

Mikolaj commented Feb 15, 2023

Nope -DSDLmain_h_ doesn't work.

@liamzee
Copy link

liamzee commented Sep 7, 2023

Use a msys workaround; i.e, get access to msys and use the older mingw msys packages (around 2.0.x) to get it to compile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants