-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧪 [Spike] Theming “support” in HDS and Showcase - Aggregated #2611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
didoo
force-pushed
the
spike-tokens-aggregated-scrappy
branch
from
December 19, 2024 13:45
c88cb3f
to
ec7e13b
Compare
added missing dependency `nodemon`
(notice: all the dark color tokens are set to `#FF0000` on purpose, so it’s easy to debug later)
… common part can be re-used to generate themed files
…ut but it doesn’t work
… file (will be used for the showcase)
didoo
force-pushed
the
spike-tokens-aggregated-scrappy
branch
from
December 19, 2024 16:12
23c2313
to
b680000
Compare
didoo
force-pushed
the
spike-tokens-aggregated-scrappy
branch
from
December 19, 2024 19:32
b680000
to
0c44e04
Compare
… developer website
Closing now that the exploration has been completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 DO NOT MERGE 🚨
📌 Summary
This is a branch where we collect all the tests and changes done for the tokens and theming explorations, under a single branch. Later will will cherry-pick (or squash and cherry-pick) what we want to extract from the code changes.
🔗 External links
Jira tickets: