From 2997e6d375ec9ae0471993e057cdde0fe8f8390d Mon Sep 17 00:00:00 2001 From: Lee White Date: Thu, 23 Jan 2025 16:46:54 -0500 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Dylan Hyun --- .../table/advanced-table/partials/code/component-api.md | 2 +- .../table/advanced-table/partials/code/how-to-use.md | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/website/docs/components/table/advanced-table/partials/code/component-api.md b/website/docs/components/table/advanced-table/partials/code/component-api.md index 605df0ffcd..b01a0fc134 100644 --- a/website/docs/components/table/advanced-table/partials/code/component-api.md +++ b/website/docs/components/table/advanced-table/partials/code/component-api.md @@ -71,7 +71,7 @@ The Advanced Table component itself is where most of the options will be applied If set to `true`, creates a “multi-select” table which renders checkboxes in the table header and on the table rows enabling bulk interaction. Use in conjunction with `onSelectionChange` on the `Table` and `selectionKey` on each `Table::Tr`.

- **Important**: AdvancedTable does **not** support having `isSelectable` true when there are nested rows. + **Important**: Advanced Table does **not** support having `isSelectable` true when there are nested rows. Use in conjunction with `isSelectable` to pass a callback function to know the selection state. Must be used in conjunction with setting a `selectionKey` on each `Table::Tr`. diff --git a/website/docs/components/table/advanced-table/partials/code/how-to-use.md b/website/docs/components/table/advanced-table/partials/code/how-to-use.md index 3f76f47537..3e544813e9 100644 --- a/website/docs/components/table/advanced-table/partials/code/how-to-use.md +++ b/website/docs/components/table/advanced-table/partials/code/how-to-use.md @@ -116,7 +116,7 @@ It is not currently supported to have `@isStriped`, multi-select, or sortable co !!! -Similar to the basic AdvancedTable, you can insert your own content into the `:body` block and the component will take care of looping over the `@model` provided for the parent and nested rows. The component adds the expand/collapse button to the `[B].Th` component in each row that has children. +Similar to the basic Advanced Table, you can insert your own content into the `:body` block and the component will take care of looping over the `@model` provided for the parent and nested rows. The component adds the expand/collapse button to the `[B].Th` component in each row that has children. ```handlebars @@ -233,7 +233,7 @@ By default, the sort order is set to ascending. To indicate that the column defi To implement a custom sort callback on a column: -1. add a custom function as the value for `sortingFunction` in the column hash, +1. add a custom function as the value for `sortingFunction` in the column hash. 2. include a custom `onSort` action in your Table invocation to track the sorting order and use it in the custom sorting function. This is useful for cases where the key might not be A-Z or 0-9 sortable by default, e.g., status, and you’re otherwise unable to influence the shape of the data in the model. @@ -298,7 +298,7 @@ customOnSort(_sortBy, sortOrder) { ### Density -To create a condensed or spacious Table, add `@density` to the Table’s invocation. Note that it only affects the Table body, not the Table header. +To create a condensed or spacious Advanced Table, add `@density` to the Advanced Table’s invocation. Note that it only affects the table body, not the table header. ```handlebars