Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate LZ contracts from the relay repo #1184

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: migrate LZ contracts from the relay repo #1184

wants to merge 1 commit into from

Conversation

natanasow
Copy link
Contributor

Description:

Related issue(s):

Fixes #1183

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@natanasow natanasow requested review from a team as code owners January 17, 2025 10:55
@natanasow natanasow self-assigned this Jan 17, 2025
@natanasow natanasow added the enhancement New feature or request label Jan 17, 2025
@natanasow natanasow added this to the 0.12.0 milestone Jan 17, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Test Results

 17 files  ±0   83 suites  +1   12m 21s ⏱️ +2s
294 tests +9  288 ✅ +10  6 💤 ±0  0 ❌  - 1 
303 runs  +1  296 ✅ + 2  7 💤 ±0  0 ❌  - 1 

Results for commit 77e71e6. ± Comparison against base commit 74c78d1.

This pull request removes 1 and adds 10 tests. Note that renamed tests count towards both. 
"before all" hook for "should be able to execute burnToken" ‑ TokenCreateContract Test Suite "before all" hook for "should be able to execute burnToken"

should be able to compare tokens created from system contract and hapi ‑ TokenCreateContract Test Suite Hapi vs Ethereum token create test should be able to compare tokens created from system contract and hapi
should be able to execute burnToken ‑ TokenCreateContract Test Suite should be able to execute burnToken
should be able to execute createFungibleToken ‑ TokenCreateContract Test Suite should be able to execute createFungibleToken
should be able to execute createFungibleTokenWithCustomFees ‑ TokenCreateContract Test Suite should be able to execute createFungibleTokenWithCustomFees
should be able to execute createNonFungibleToken ‑ TokenCreateContract Test Suite should be able to execute createNonFungibleToken
should be able to execute createNonFungibleTokenWithCustomFees ‑ TokenCreateContract Test Suite should be able to execute createNonFungibleTokenWithCustomFees
should be able to execute dissociateToken and associateToken ‑ TokenCreateContract Test Suite should be able to execute dissociateToken and associateToken
should be able to execute dissociateTokens and associateTokens ‑ TokenCreateContract Test Suite should be able to execute dissociateTokens and associateTokens
should be able to execute grantTokenKyc ‑ TokenCreateContract Test Suite should be able to execute grantTokenKyc
should be able to execute mintToken ‑ TokenCreateContract Test Suite should be able to execute mintToken

♻️ This comment has been updated with latest results.

quiet-node
quiet-node reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we gonna add test for the contracts or will happen in follow up PRs?

@Nana-EC
Copy link
Collaborator

Nana-EC commented Jan 17, 2025

Are we gonna add test for the contracts or will happen in follow up PRs?

We have test coverage on the relay side. The challenge was the hardhat sub module issue but also we've found LZ doesn't support ethers v6 so we're thinking on that.
For now just having the reference contracts is what we need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quiet-node quiet-node quiet-node left review comments

@konstantinabl konstantinabl Awaiting requested review from konstantinabl konstantinabl is a code owner automatically assigned from hashgraph/hedera-smart-contracts

At least 1 approving review is required to merge this pull request.

Assignees

@natanasow natanasow

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

Migrate LZ contracts from the relay repo
3 participants
@natanasow @Nana-EC @quiet-node