feat: Add ENTITY_COUNTS state in EntityIdService
#17421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17421 +/- ##
============================================
+ Coverage 68.91% 68.94% +0.03%
- Complexity 22667 22700 +33
============================================
Files 2613 2615 +2
Lines 97892 98006 +114
Branches 10156 10158 +2
============================================
+ Hits 67463 67572 +109
- Misses 26613 26617 +4
- Partials 3816 3817 +1
... and 9 files with indirect coverage changes |
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Neeharika-Sompalli
requested review from
a team and
tinker-michaelj
as code owners
tinker-michaelj
previously approved these changes
Jan 17, 2025
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
tinker-michaelj
approved these changes
Jan 17, 2025
hedera-node/hedera-app-spi/src/main/java/com/hedera/node/app/spi/validation/EntityType.java
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/ids/schemas/V0590EntityIdSchema.java
Show resolved
Hide resolved
artemananiev
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #17316
Fixes #17427
ENTITY_COUNTSstate inEntityIdServicein 0.59ENTITY_COUNTSKVState.sizewill be deprecated and should not be used any more. Future PRs will remove all the references of it and useENTITY_COUNTSstate insteadTesting: