Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hip 551 hapi verbs #17390

Open
wants to merge 5 commits into
base: hip-551-batch-txs
Choose a base branch
from
Open

Conversation

JivkoKelchev
Copy link
Contributor

@JivkoKelchev JivkoKelchev commented Jan 15, 2025

Description:

Adds public static HapiAtomicBatch atomicBatch(HapiTxnOp<?>... ops) in TxnVerbs for test clients.

Related issue(s):
Fixes 17375

@JivkoKelchev JivkoKelchev self-assigned this Jan 15, 2025
@JivkoKelchev JivkoKelchev added this to the v0.60 milestone Jan 15, 2025
@JivkoKelchev JivkoKelchev marked this pull request as ready for review January 15, 2025 12:46
@JivkoKelchev JivkoKelchev requested review from a team as code owners January 15, 2025 12:46
Copy link

codacy-production bot commented Jan 15, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.20% (target: -1.00%) 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (818cdbc) 96472 69078 71.60%
Head commit (0d52a66) 96549 (+77) 69322 (+244) 71.80% (+0.20%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17390) 1 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.94%. Comparing base (818cdbc) to head (0d52a66).
Report is 7 commits behind head on hip-551-batch-txs.

Files with missing lines Patch % Lines
...m/hedera/node/app/services/ServiceScopeLookup.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##             hip-551-batch-txs   #17390      +/-   ##
=======================================================
+ Coverage                67.72%   67.94%   +0.21%     
- Complexity               22204    22348     +144     
=======================================================
  Files                     2596     2608      +12     
  Lines                    96689    96919     +230     
  Branches                 10082    10099      +17     
=======================================================
+ Hits                     65486    65848     +362     
+ Misses                   27459    27309     -150     
- Partials                  3744     3762      +18     
Files with missing lines Coverage Δ
...m/hedera/node/app/services/ServiceScopeLookup.java 50.00% <0.00%> (ø)

... and 37 files with indirect coverage changes

Impacted file tree graph

@JivkoKelchev JivkoKelchev linked an issue Jan 15, 2025 that may be closed by this pull request
Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the HAPI verbs
2 participants