Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap order of gossip endpoints when creating rosters. #16608

Open
Tracked by #14706
edward-swirldslabs opened this issue Nov 14, 2024 · 0 comments
Open
Tracked by #14706

Swap order of gossip endpoints when creating rosters. #16608

edward-swirldslabs opened this issue Nov 14, 2024 · 0 comments
Assignees

Comments

@edward-swirldslabs
Copy link
Contributor

edward-swirldslabs commented Nov 14, 2024

Background

As of DAB Phase 2, there are 2 gossip ServiceEndpoints in the Node.proto. The "internal ip address" is at index 0 and the `external ip address" is at index 1 in the list.

Going forward for the near term, Rosters should have the "external ip address" at index 0 and the platform will only only use the "external" ip address when connecting to peers.

When constructing Rosters from the node.proto, the order of endpoints needs to be switched so that the external ip address is at index 0.

Acceptance Criteria

All places where rosters are constructed using node.proto data have the gossip endpoints swapped so that the external ip address is at index 0.

Notes

In the future, the internal IP address will be taken out of the address book and roster to be provided as node configuration. This has not been designed yet, so the data remains as content here in this list.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Services Team Nov 14, 2024
@petreze petreze moved this from 📋 Backlog to 👷🏼‍♀️ In Progress in Services Team Nov 15, 2024
@petreze petreze self-assigned this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👷🏼‍♀️ In Progress
Development

No branches or pull requests

2 participants